Closed
Bug 1041625
Opened 11 years ago
Closed 11 years ago
[Search/Rocketbar] Color Matching Status Bar
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(feature-b2g:2.1, b2g-v2.1 verified)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | verified |
People
(Reporter: epang, Assigned: mikehenrty)
References
Details
(Whiteboard: [systemsfe][tako])
User Story
Attachments
(11 files, 4 obsolete files)
3.10 MB,
image/jpeg
|
Details | |
171.04 KB,
image/png
|
Details | |
353.93 KB,
image/png
|
Details | |
74.30 KB,
image/png
|
Details | |
45.16 KB,
image/png
|
Details | |
438.75 KB,
image/png
|
Details | |
19.71 KB,
image/png
|
Details | |
49.42 KB,
image/png
|
Details | |
92.92 KB,
image/png
|
Details | |
118.74 KB,
image/png
|
Details | |
90.96 KB,
image/png
|
Details |
This bug is to track the work that needs to be done for the colour matching status bar.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
User Story: (updated)
Updated•11 years ago
|
Assignee: nobody → mhenretty
feature-b2g: --- → 2.1
Whiteboard: [systemsfe] → [systemsfe][tako]
Target Milestone: --- → 2.1 S1 (1aug)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8460033 [details]
Visual Spec
Eric, Diego pointed out that this spec doesn't have the actual colors for the status bar in them. Are we missing part of the spec?
Flags: needinfo?(epang)
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Michael Henretty [:mhenretty] from comment #2)
> Comment on attachment 8460033 [details]
> Visual Spec
>
> Eric, Diego pointed out that this spec doesn't have the actual colors for
> the status bar in them. Are we missing part of the spec?
Hi Michael, I left out the colours of the status bar since they should be colour matched to the header. With the spec'ed out overlay on top.
The only places I included the colours are on the homescreen (#000000) and browser (#ffffff) since these screens do not have headers and will not change.
Let me know if I'm not making sense :)
Eric
Flags: needinfo?(epang)
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Eric Pang [:epang] from comment #3)
> (In reply to Michael Henretty [:mhenretty] from comment #2)
> > Comment on attachment 8460033 [details]
> > Visual Spec
> >
> > Eric, Diego pointed out that this spec doesn't have the actual colors for
> > the status bar in them. Are we missing part of the spec?
>
> Hi Michael, I left out the colours of the status bar since they should be
> colour matched to the header. With the spec'ed out overlay on top.
>
> The only places I included the colours are on the homescreen (#000000) and
> browser (#ffffff) since these screens do not have headers and will not
> change.
>
> Let me know if I'm not making sense :)
> Eric
Can you do the calculations for us, and provide the RGB or hex values in the spec? Each app can only specify a final statusbar color, and so making it black with an opacity adds complication (ie, does the statusbar always overlap the header, what happens when the header goes away, etc.).
Flags: needinfo?(epang)
Reporter | ||
Comment 5•11 years ago
|
||
Hi Michael,
I've updated the spec so that the hex values are used (instead of the overlay).
Let me know if you have any questions or need anything else.
Thanks!
Attachment #8460033 -
Attachment is obsolete: true
Flags: needinfo?(epang) → needinfo?(mhenretty)
Updated•11 years ago
|
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
Assignee | ||
Comment 7•11 years ago
|
||
Updated Visual Spec
Attachment #8464554 -
Attachment is obsolete: true
Assignee | ||
Comment 8•11 years ago
|
||
Eric, based on https://bugzilla.mozilla.org/show_bug.cgi?id=1041896#c9, the statusbar will automatically add a 0.1 opacity black overlay to the color we specify for theme. Can you update the spec to take this into account?
Flags: needinfo?(epang)
Reporter | ||
Comment 9•11 years ago
|
||
Hey Michael,
I've updated the spec to take into account the 10% black overlay.
Pretty much all screens have changed besides the ones with a black status bar.
I've also realized that I should have added Market Place. It's now in the spec and uses the same status bar as settings.
Let me know if anything else is needed, thanks!
Flags: needinfo?(epang)
Reporter | ||
Updated•11 years ago
|
Attachment #8470321 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
User Story: (updated)
Reporter | ||
Comment 10•11 years ago
|
||
latest visual spec
Attachment #8475919 -
Attachment is obsolete: true
Updated•11 years ago
|
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Assignee | ||
Comment 11•11 years ago
|
||
The only work left to do here is in the callcreen. However, that relies on the attention window [1] which is not 2.1 blocking. Although it's being actively worked on, it is unlikely that will land in time for us to make the changes necessary to the callscreen app to close that by FL. I'm going to call that a polish bug, and close this user story since it is done except for callscreen (which was added to the spec late in the game anyway).
1.) https://bugzilla.mozilla.org/show_bug.cgi?id=1052795#c3
Comment 12•10 years ago
|
||
Hi Mike,
Could you help with it, thanks.
This issue has been verified unsuccessfully on Flame 2.1
The status bar do not show at active all page.
See attachment: Active Call.png
Reproducing rate: 5/5
Flame 2.1 versions:
Gaia-Rev dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID 20141203001205
Version 34.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141203.034907
FW-Date Wed Dec 3 03:49:18 EST 2014
Bootloader L1TC00011880
Flags: needinfo?(mlien)
Comment 13•10 years ago
|
||
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
Comment 16•10 years ago
|
||
Comment 17•10 years ago
|
||
Comment 18•10 years ago
|
||
Comment 19•10 years ago
|
||
Comment 20•10 years ago
|
||
Comment 21•10 years ago
|
||
Comment 22•10 years ago
|
||
refer to comment 11, callscreen is the exception one
You need to log in
before you can comment on or make changes to this bug.
Description
•