1041625 - [Search/Rocketbar] Color Matching Status Bar

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Eric Pang [:epang] UX]

This bug is to track the work that needs to be done for the colour matching status bar.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Visual Spec

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8460033 [details]
Visual Spec

Eric, Diego pointed out that this spec doesn't have the actual colors for the status bar in them. Are we missing part of the spec?

Comment 3

[Eric Pang [:epang] UX]

(In reply to Michael Henretty [:mhenretty] from comment #2)
> Comment on attachment 8460033 [details]
> Visual Spec
> 
> Eric, Diego pointed out that this spec doesn't have the actual colors for
> the status bar in them. Are we missing part of the spec?

Hi Michael, I left out the colours of the status bar since they should be colour matched to the header.  With the spec'ed out overlay on top.

The only places I included the colours are on the homescreen (#000000) and browser (#ffffff) since these screens do not have headers and will not change.

Let me know if I'm not making sense :)
Eric

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Eric Pang [:epang] from comment #3)
> (In reply to Michael Henretty [:mhenretty] from comment #2)
> > Comment on attachment 8460033 [details]
> > Visual Spec
> > 
> > Eric, Diego pointed out that this spec doesn't have the actual colors for
> > the status bar in them. Are we missing part of the spec?
> 
> Hi Michael, I left out the colours of the status bar since they should be
> colour matched to the header.  With the spec'ed out overlay on top.
> 
> The only places I included the colours are on the homescreen (#000000) and
> browser (#ffffff) since these screens do not have headers and will not
> change.
> 
> Let me know if I'm not making sense :)
> Eric

Can you do the calculations for us, and provide the RGB or hex values in the spec? Each app can only specify a final statusbar color, and so making it black with an opacity adds complication (ie, does the statusbar always overlap the header, what happens when the header goes away, etc.).

Comment 5

[Eric Pang [:epang] UX]

Attachment: Updated Visual Spec.jpg

Hi Michael,

I've updated the spec so that the hex values are used (instead of the overlay).

Let me know if you have any questions or need anything else.

Thanks!

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Looks good to me, thanks Eric!

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Visual Spec] now with callscreen

Updated Visual Spec

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Eric, based on https://bugzilla.mozilla.org/show_bug.cgi?id=1041896#c9, the statusbar will automatically add a 0.1 opacity black overlay to the color we specify for theme. Can you update the spec to take this into account?

Comment 9

[Eric Pang [:epang] UX]

Attachment: [Visual Spec] now with callscreen and Market Place

Hey Michael,

I've updated the spec to take into account the 10% black overlay.
Pretty much all screens have changed besides the ones with a black status bar.

I've also realized that I should have added Market Place.  It's now in the spec and uses the same status bar as settings.

Let me know if anything else is needed, thanks!

Comment 10

[Eric Pang [:epang] UX]

Attachment: [Visual Spec]

latest visual spec

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

The only work left to do here is in the callcreen. However, that relies on the attention window [1] which is not 2.1 blocking. Although it's being actively worked on, it is unlikely that will land in time for us to make the changes necessary to the callscreen app to close that by FL. I'm going to call that a polish bug, and close this user story since it is done except for callscreen (which was added to the spec late in the game anyway).

1.) https://bugzilla.mozilla.org/show_bug.cgi?id=1052795#c3

Comment 12

[Sue]

Attachment: Active Call

Hi Mike,
Could you help with it, thanks.
This issue has been verified unsuccessfully on Flame 2.1
The status bar do not show at active all page.
See attachment: Active Call.png
Reproducing rate: 5/5
Flame 2.1 versions:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141203.034907
FW-Date         Wed Dec  3 03:49:18 EST 2014
Bootloader      L1TC00011880

Comment 13

[Sue]

Attachment: Homescreen

Comment 14

[Sue]

Attachment: Productivity

Comment 15

[Sue]

Attachment: Comms

Comment 16

[Sue]

Attachment: Media

Comment 17

[Sue]

Attachment: Browser

Comment 18

[Sue]

Attachment: Settings

Comment 19

[Sue]

Attachment: Packaged / Hosted App

Comment 20

[Sue]

Attachment: System Tray

Comment 21

[Sue]

Attachment: Market Place

Comment 22

[Mike Lien[:mlien]]

refer to comment 11, callscreen is the exception one